fixing typo in NOT_IN

redis · May 2, 2024 · 8f46dd9 · 8f46dd9
1 parent 31d99ac
commit 8f46dd9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/aredis_om/model/model.py b/aredis_om/model/model.py
@@ -688,7 +688,7 @@ def resolve_value(
             elif op is Operators.NOT_IN:
                 # TODO: Implement NOT_IN, test this...
                 expanded_value = cls.expand_tag_value(value)
-                result += "-(@{field_name}):{{{expanded_value}}}".format(
+                result += "-(@{field_name}:{{{expanded_value}}})".format(
                     field_name=field_name, expanded_value=expanded_value
                 )
 

diff --git a/tests/test_json_model.py b/tests/test_json_model.py
@@ -454,6 +454,15 @@ async def test_in_query(members, m):
     )
     assert actual == [member2, member1, member3]
 
+@py_test_mark_asyncio
+async def test_not_in_query(members, m):
+    member1, member2, member3 = members
+    actual = await (
+        m.Member.find(m.Member.pk >> [member2.pk, member3.pk])
+        .sort_by("age")
+        .all()
+    )
+    assert actual == [ member1]
 
 @py_test_mark_asyncio
 async def test_update_query(members, m):