Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defenition is missing "ca" when connecting with tls #2679

Open
huineng opened this issue Dec 31, 2023 · 1 comment
Open

Defenition is missing "ca" when connecting with tls #2679

huineng opened this issue Dec 31, 2023 · 1 comment
Labels
Bug

Comments

@huineng
Copy link

huineng commented Dec 31, 2023

Description

ca?: string is missing for socket options

i bypass it now like this

(options.socket as any).ca

image

Node.js Version

v18.18.2

Redis Server Version

6.2.13

Node Redis Version

4.6.12

Platform

mac

Logs

No response
@huineng huineng added the Bug label Dec 31, 2023
@leibale leibale mentioned this issue Jan 2, 2024
Merged
3 tasks
@leibale
Copy link
Contributor

leibale commented Jan 16, 2024

https://github.com/redis/node-redis/pull/2664/files/3dea4006e7a2c0dad0567591fc06ad9879a9b44e#diff-6dc6679ebf8ec73bbf010731349f115b52f0a2e2a3b9a4e5cf93e6897cc015bdR31

I think this solves it, need to check and cherry-pick to v4...

leibale added a commit that referenced this issue Feb 12, 2024
@leibale
fix #2679 - fix socket types, and clean some code
77ecdf2
@leibale leibale mentioned this issue Feb 12, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huineng @leibale