Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'make test' test failures #3157

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Fix 'make test' test failures #3157

merged 1 commit into from
Feb 4, 2025

Conversation

ggivo
Copy link
Contributor

@ggivo ggivo commented Feb 3, 2025

In case REDIS_STACK_VERSION is not explicitly set, an empty string is propagated by surefire plugin causing containerised test infra to fail to start

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

In case REDIS_STACK_VERSION is not explicitly set empty string is propagated by surefire pluign causing containerised test infra to fail to start
@ggivo ggivo requested a review from tishun February 3, 2025 15:27
Copy link
Collaborator

@tishun tishun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tishun tishun merged commit 2086820 into redis:main Feb 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants