-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpsForGeo producing "READONLY You can't write against a read only replica " on READS... #3032
Merged
tishun
merged 4 commits into
redis:main
from
ggivo:1813-georadius-fails-on-readonly-replica
Nov 5, 2024
Merged
OpsForGeo producing "READONLY You can't write against a read only replica " on READS... #3032
tishun
merged 4 commits into
redis:main
from
ggivo:1813-georadius-fails-on-readonly-replica
Nov 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lica" on READS... only if master & replica configured redis#1813 Divert pure read intentions of georadius and georadiusbymember commands (variants that do not use STORE/STOREDIST) to GEORADIUS_RO/GEORADIUSBYMEMBER_RO This will unify the behaviour between Cluster and Redis Standalone/Replica arrangements Relates to issues redis#1481 redis#2568 redis#2871 Closes redis#1813
A bit of background.. |
tishun
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's merge it after we release 6.5.0.RELEASE |
tishun
pushed a commit
that referenced
this pull request
Dec 1, 2024
…lica " on READS... (#3032) * OpsForGeo producing "READONLY You can't write against a read only replica" on READS... only if master & replica configured #1813 Divert pure read intentions of georadius and georadiusbymember commands (variants that do not use STORE/STOREDIST) to GEORADIUS_RO/GEORADIUSBYMEMBER_RO This will unify the behaviour between Cluster and Redis Standalone/Replica arrangements Relates to issues #1481 #2568 #2871 Closes #1813 * Fix tests * Remove unused methods * Fix tests and add tests withArgs
thachlp
pushed a commit
to thachlp/lettuce
that referenced
this pull request
Dec 31, 2024
…lica " on READS... (redis#3032) * OpsForGeo producing "READONLY You can't write against a read only replica" on READS... only if master & replica configured redis#1813 Divert pure read intentions of georadius and georadiusbymember commands (variants that do not use STORE/STOREDIST) to GEORADIUS_RO/GEORADIUSBYMEMBER_RO This will unify the behaviour between Cluster and Redis Standalone/Replica arrangements Relates to issues redis#1481 redis#2568 redis#2871 Closes redis#1813 * Fix tests * Remove unused methods * Fix tests and add tests withArgs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only if master & replica configured
Divert pure read intentions of georadius and georadiusbymember commands (variants that do not use STORE/STOREDIST) to GEORADIUS_RO/GEORADIUSBYMEMBER_RO This will unify the behavior between Cluster and Redis Standalone/Replica arrangements
Relates to issues #1481 #2568 #2871
Closes #1813
Make sure that:
mvn formatter:format
target. Don’t submit any formatting related changes.