Support for ACL commands #1538

[sokomishalov]

Draft PR for ACL commands API.
My main concern - should we provide higher abstractions for rules?

[mp911de]

Good first draft. Let's move AclCategory into an api package so we don't depend on the model package.

Can we also make the username a String instead of using the keytype K?

Re rules abstraction: I think it makes sense to provide an args object to provide rules.

[mp911de]

In preparation for Lettuce 6.1 M1, I'd like to move this change to M2 so that we can ship 6.1 M1 in the next days.

[codecov]

Codecov Report

Merging #1602 (a12d34c) into main (4a98e5b) will decrease coverage by 0.47%.
The diff coverage is 52.89%.

@@             Coverage Diff              @@
##               main    #1602      +/-   ##
============================================
- Coverage     78.77%   78.30%   -0.48%     
- Complexity     6443     6509      +66     
============================================
  Files           481      487       +6     
  Lines         21735    22061     +326     
  Branches       2377     2412      +35     
============================================
+ Hits          17122    17275     +153     
- Misses         3525     3671     +146     
- Partials       1088     1115      +27     

Impacted Files	Coverage Δ	Complexity Δ
...io/lettuce/core/AbstractRedisReactiveCommands.java	86.91% <0.00%> (-2.51%)	442.00 <0.00> (ø)
.../io/lettuce/core/models/command/CommandDetail.java	100.00% <ø> (ø)	18.00 <0.00> (ø)
.../java/io/lettuce/core/output/ListOfMapsOutput.java	90.47% <0.00%> (-9.53%)	7.00 <0.00> (ø)
...e/api/coroutines/RedisAclCoroutinesCommandsImpl.kt	6.25% <6.25%> (ø)	1.00 <1.00> (?)
src/main/java/io/lettuce/core/AclSetuserArgs.java	19.87% <19.87%> (ø)	10.00 <10.00> (?)
...n/java/io/lettuce/core/output/UserRulesOutput.java	35.71% <35.71%> (ø)	5.00 <5.00> (?)
...in/java/io/lettuce/core/output/EnumListOutput.java	76.47% <76.47%> (ø)	5.00 <5.00> (?)
...va/io/lettuce/core/AbstractRedisAsyncCommands.java	96.31% <100.00%> (+0.11%)	467.00 <15.00> (+15.00)
src/main/java/io/lettuce/core/AclCategory.java	100.00% <100.00%> (ø)	1.00 <1.00> (?)
...main/java/io/lettuce/core/RedisCommandBuilder.java	95.46% <100.00%> (+0.14%)	511.00 <16.00> (+16.00)
... and 18 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a98e5b...a12d34c. Read the comment docs.

[sokomishalov]

I've made some fixes according to the first review

[mp911de]

This should be rather an EnumSet. I will take care of this during the merge.

[mp911de]

Thank you for your contribution. That's merged and polished now. I removed UserRulesOutput because it didn't consider nested lists. We could introduce a parser for List<Object> that creates an user object and that can be translated into ACL SET USER args.