Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let coroutines dispatch-method be flowable #1567

Closed

Conversation

sokomishalov
Copy link
Collaborator

@sokomishalov sokomishalov commented Dec 24, 2020

...Instead of being suspendable and awaiting only for the first emitted element.
And yes, this is a breaking change (however, coroutines API is still marked as experimental).

@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #1567 (c02b5f2) into main (9e30d62) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1567      +/-   ##
============================================
- Coverage     78.64%   78.58%   -0.06%     
+ Complexity     6341     6340       -1     
============================================
  Files           477      477              
  Lines         21335    21335              
  Branches       2334     2334              
============================================
- Hits          16779    16767      -12     
- Misses         3479     3491      +12     
  Partials       1077     1077              
Impacted Files Coverage Δ Complexity Δ
.../api/coroutines/BaseRedisCoroutinesCommandsImpl.kt 5.55% <0.00%> (ø) 1.00 <0.00> (ø)
.../coroutines/RedisSentinelCoroutinesCommandsImpl.kt 13.63% <0.00%> (ø) 3.00 <0.00> (ø)
...o/lettuce/core/event/command/CommandBaseEvent.java 53.84% <0.00%> (-46.16%) 3.00% <0.00%> (-1.00%)
...n/java/io/lettuce/core/cluster/ClusterCommand.java 70.73% <0.00%> (-17.08%) 18.00% <0.00%> (-1.00%)
...ce/core/masterreplica/SentinelTopologyRefresh.java 84.96% <0.00%> (-0.66%) 35.00% <0.00%> (ø%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 87.39% <0.00%> (ø) 1.00% <0.00%> (ø%)
.../io/lettuce/core/protocol/ReconnectionHandler.java 79.72% <0.00%> (ø) 22.00% <0.00%> (ø%)
src/main/java/io/lettuce/core/RedisPublisher.java 79.28% <0.00%> (+0.59%) 5.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e30d62...c02b5f2. Read the comment docs.

@mp911de mp911de added this to the 6.0.2 milestone Jan 8, 2021
@mp911de mp911de added type: task A general task type: breaking Breaking change labels Jan 8, 2021
mp911de pushed a commit that referenced this pull request Jan 8, 2021
mp911de pushed a commit that referenced this pull request Jan 8, 2021
@mp911de mp911de self-assigned this Jan 8, 2021
@mp911de
Copy link
Collaborator

mp911de commented Jan 8, 2021

Thanks a lot, that's merged now for 6.0.2 and 6.1.

@mp911de mp911de closed this Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking Breaking change type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants