Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netty 4.1.56 #1556

Closed
wants to merge 1 commit into from
Closed

netty 4.1.56 #1556

wants to merge 1 commit into from

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Dec 8, 2020

https://netty.io/news/2020/12/17/4-1-56-Final.html

As this release includes a fix for a possible infinite loop it's advised to upgrade
asap if you use 4.1.55.Final.

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #1556 (e694516) into main (34476f5) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1556      +/-   ##
============================================
- Coverage     78.68%   78.61%   -0.08%     
+ Complexity     6340     6332       -8     
============================================
  Files           476      476              
  Lines         21318    21318              
  Branches       2333     2333              
============================================
- Hits          16774    16759      -15     
- Misses         3472     3479       +7     
- Partials       1072     1080       +8     
Impacted Files Coverage Δ Complexity Δ
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 77.12% <0.00%> (-2.62%) 37.00% <0.00%> (-2.00%)
.../java/io/lettuce/core/protocol/CommandHandler.java 73.60% <0.00%> (-2.04%) 110.00% <0.00%> (-4.00%)
.../io/lettuce/core/protocol/ReconnectionHandler.java 78.37% <0.00%> (-1.36%) 20.00% <0.00%> (-2.00%)
...ce/core/masterreplica/SentinelTopologyRefresh.java 84.96% <0.00%> (-0.66%) 35.00% <0.00%> (ø%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 86.95% <0.00%> (-0.44%) 1.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34476f5...e694516. Read the comment docs.

@sullis sullis changed the title netty 4.1.55 netty 4.1.56 Dec 18, 2020
@sullis
Copy link
Contributor Author

sullis commented Dec 20, 2020

WDYT? @mp911de

@mp911de
Copy link
Collaborator

mp911de commented Dec 20, 2020

Dependency upgrade pull requests create more work than value as they require additional ticket handling, backports, and branch tests. Please do not submit dependency upgrades in the future.

@mp911de mp911de added the type: dependency-upgrade A dependency upgrade label Dec 20, 2020
@mp911de
Copy link
Collaborator

mp911de commented Dec 20, 2020

That's merged and backported now.

@mp911de mp911de closed this Dec 20, 2020
@sullis sullis deleted the netty-4.1.55 branch December 21, 2020 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants