Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve username from URI when RedisURI is built from URL #1242

Closed
wants to merge 1 commit into from
Closed

Retrieve username from URI when RedisURI is built from URL #1242

wants to merge 1 commit into from

Conversation

gkorland
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 21, 2020

Codecov Report

Merging #1242 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1242      +/-   ##
============================================
+ Coverage     78.75%   78.82%   +0.06%     
- Complexity     5776     5835      +59     
============================================
  Files           423      423              
  Lines         19669    19675       +6     
  Branches       2214     2216       +2     
============================================
+ Hits          15491    15509      +18     
+ Misses         3134     3127       -7     
+ Partials       1044     1039       -5     
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/lettuce/core/RedisURI.java 92.49% <100.00%> (+0.11%) 145.00 <0.00> (+3.00)
...ttuce/core/support/ClientResourcesFactoryBean.java 46.66% <0.00%> (-13.34%) 4.00% <0.00%> (-1.00%)
...e/core/metrics/DefaultCommandLatencyCollector.java 76.66% <0.00%> (-0.84%) 22.00% <0.00%> (ø%)
...va/io/lettuce/core/protocol/RedisStateMachine.java 79.18% <0.00%> (-0.69%) 89.00% <0.00%> (+8.00%) ⬇️
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 87.82% <0.00%> (+0.43%) 1.00% <0.00%> (ø%)
...main/java/io/lettuce/core/AbstractRedisClient.java 77.43% <0.00%> (+0.51%) 47.00% <0.00%> (+1.00%)
src/main/java/io/lettuce/core/ScanStream.java 87.66% <0.00%> (+1.29%) 24.00% <0.00%> (ø%)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 77.77% <0.00%> (+1.96%) 37.00% <0.00%> (+5.00%)
...lettuce/core/internal/AsyncConnectionProvider.java 87.65% <0.00%> (+2.46%) 17.00% <0.00%> (+1.00%)
...n/java/io/lettuce/core/cluster/ClusterCommand.java 78.04% <0.00%> (+4.87%) 19.00% <0.00%> (ø%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efed1c6...8a0c390. Read the comment docs.

@mp911de mp911de changed the title Retrieve password from URI when RedisURI is built from URL Retrieve username from URI when RedisURI is built from URL Mar 21, 2020
@mp911de mp911de added the type: feature A new feature label Mar 21, 2020
@mp911de mp911de added this to the 6.0 M1 milestone Mar 21, 2020
mp911de added a commit that referenced this pull request Mar 21, 2020
Add author tags. Reformat code.
@mp911de
Copy link
Collaborator

mp911de commented Mar 21, 2020

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Mar 21, 2020
@gkorland gkorland deleted the url_username branch March 21, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants