Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firstResponseLatency depends on command completion time #491

Closed
mp911de opened this issue Mar 20, 2017 · 2 comments
Closed

firstResponseLatency depends on command completion time #491

mp911de opened this issue Mar 20, 2017 · 2 comments
Labels
type: bug A general bug
Milestone
Lettuce 4.3.2

Comments

@mp911de
Copy link
Collaborator

mp911de commented Mar 20, 2017

firstResponseLatency depends on command completion time, not the sent time. The longer command completion takes, the higher first response latency is.

It should depend on sent time because first response happens only once on the first completion and should not depend on command completion

CommandHandler.recordLatency:

 long firstResponseLatency = nanoTime() - withLatency.getFirstResponse();
@mp911de mp911de added the type: bug A general bug label Mar 20, 2017
@mp911de mp911de added this to the Lettuce 4.3.2 milestone Mar 20, 2017
mp911de added a commit that referenced this issue Mar 20, 2017
@mp911de
Calculate first response metrics from sent time #491
7063839 
Latency collection calculates firstResponse latency using sent time as reference. First response latency reflects the time between sending and receiving (processing) the first chunk of data for the command.

Previously firstResponse latency was calculated between first response time and command completion.
mp911de added a commit that referenced this issue Mar 20, 2017
@mp911de
Calculate first response metrics from sent time #491
385d6af 
Latency collection calculates firstResponse latency using sent time as reference. First response latency reflects the time between sending and receiving (processing) the first chunk of data for the command.

Previously firstResponse latency was calculated between first response time and command completion.
mp911de added a commit that referenced this issue Mar 20, 2017
@mp911de
Calculate first response metrics from sent time #491
1a66681 
Latency collection calculates firstResponse latency using sent time as reference. First response latency reflects the time between sending and receiving (processing) the first chunk of data for the command.

Previously firstResponse latency was calculated between first response time and command completion.
@mp911de mp911de closed this as completed Mar 20, 2017
@shankyty
Copy link

Thanks for quick fix, which version on maven repo will have this fix?

@mp911de
Copy link
Collaborator Author

mp911de commented Mar 21, 2017 

<repositories>
  <repository>
    <id>sonatype-nexus-snapshots</id>
    <url>https://oss.sonatype.org/content/repositories/snapshots</url>
    <snapshots>
      <enabled>true</enabled>
    </snapshots>
  </repository>
</repositories>

Use version 4.3.2-SNAPSHOT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
Lettuce 4.3.2
Development

No branches or pull requests
2 participants
@mp911de @shankyty