Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACL DELUSER does not work correctly with UTF-8 Japanese characters #3178

Closed
tishun opened this issue Feb 13, 2025 · 0 comments · Fixed by #3179
Closed

ACL DELUSER does not work correctly with UTF-8 Japanese characters #3178

tishun opened this issue Feb 13, 2025 · 0 comments · Fixed by #3179
Milestone
Async

Comments

@tishun
Copy link
Collaborator

tishun commented Feb 13, 2025

Bug Report

As part of #3075 we've made it possible to create users with non-latin UTF-8 characters

Current Behavior

The AclCommandIntegrationTests fail due to the fact that they could not delete the newly created user.

Stack trace 
[INFO] Results:
[INFO] 
Error:  Failures: 
Error:    AclCommandIntegrationTests.aclList:134 
Expected size: 2 but was: 1 in:
["user default on nopass sanitize-payload ~* &* +@all"]
Error:    AclCommandIntegrationTests.aclUsers:164 
Expected size: 2 but was: 1 in:
["default"]
Error:    AclReactiveCommandIntegrationTests>AclCommandIntegrationTests.aclList:134 
Expected size: 2 but was: 1 in:
["user default on nopass sanitize-payload ~* &* +@all"]
Error:    AclReactiveCommandIntegrationTests>AclCommandIntegrationTests.aclUsers:164 
Expected size: 2 but was: 1 in:
["default"]
[INFO] 
Error:  Tests run: 2636, Failures: 4, Errors: 0, Skipped: 58```

</details>

#### Expected behavior/code

- fix pipeline to not fail (as a temporary first step)
- fix the issue to enable deleting a user

#### Environment

- Lettuce version(s): 6.5.x
- Redis version: any
@tishun tishun added this to the Async milestone Feb 13, 2025
@tishun tishun mentioned this issue Feb 13, 2025
Merged
4 tasks
tishun added a commit that referenced this issue Feb 13, 2025
@tishun @ggivo
ACL DELUSER does not work correctly with UTF-8 Japanese characters #3178
fc7bffb 
 (#3179)

* Parse strings as UTF-8

* Chores : Reduce stale issues time, fix benchmark code, remove debug messages for testcontainers

* Change method name

* Update src/test/java/io/lettuce/core/commands/AclCommandIntegrationTests.java

Co-authored-by: ggivo <ivo.gaydajiev@gmail.com>

* Remove unneeded imports

---------

Co-authored-by: ggivo <ivo.gaydajiev@gmail.com>
tishun added a commit to tishun/lettuce-core that referenced this issue Feb 19, 2025
@tishun @ggivo
ACL DELUSER does not work correctly with UTF-8 Japanese characters re…
9154b8c 
…dis#3178 (redis#3179)

* Parse strings as UTF-8

* Chores : Reduce stale issues time, fix benchmark code, remove debug messages for testcontainers

* Change method name

* Update src/test/java/io/lettuce/core/commands/AclCommandIntegrationTests.java

Co-authored-by: ggivo <ivo.gaydajiev@gmail.com>

* Remove unneeded imports

---------

Co-authored-by: ggivo <ivo.gaydajiev@gmail.com>
@tishun tishun mentioned this issue Feb 19, 2025
Merged
4 tasks
tishun added a commit that referenced this issue Feb 19, 2025
@tishun @ggivo
ACL DELUSER does not work correctly with UTF-8 Japanese characters #3178
6e998ba 
 (#3179) (#3188)

* Parse strings as UTF-8

* Chores : Reduce stale issues time, fix benchmark code, remove debug messages for testcontainers

* Change method name

* Update src/test/java/io/lettuce/core/commands/AclCommandIntegrationTests.java



* Remove unneeded imports

---------

Co-authored-by: ggivo <ivo.gaydajiev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Async
Development

Successfully merging a pull request may close this issue.

ACL DELUSER does not work correctly with UTF-8 Japanese characters #3178 tishun/lettuce-core
1 participant
@tishun