HMSET deprecated in version 4.0.0

[hodur]

HMSET has been considered deprecated since Redis 4.0.0. Instead HSET is variadic and returns the number of fields added.

I'd expect to be able to use HSET through lettuce with multiple key/value pairs. Looking at the code the obvious solutions seems to be adding String hset(K key, Map<K, V> map); to the api (along with the async and reactive equivalents). When executed against Redis servers <4.0.0 the error property on the command output would be set to what Redis throws on older versions.

[mp911de]

Thanks for the hint. It makes sense to reflect these changes in our API and introduce long hset(K, Map) including reactive and async variants and deprecate hmset. Care to submit a pull request? The API is generated and method templates can be found in src/main/templates and the generator is located in the test sources (io.lettuce.apigenerator.GenerateCommandInterfaces).

[hodur]

I'm getting errors after generating. When I run the generator on the 5.3.x branch with the code untouched it removes both dispatch(ProtocolKeyword ...) methods from all three RedisSentinelCommands interfaces.

[mp911de]

You might want to revert all touched classes except the Hash-related ones.

[mp911de]

Thank you for your contribution. That's merged, polished, and forwardported now.

[hodur]

Glad to be of help.