Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization of BITFIELD args generation #1175

Closed
ianpojman opened this issue Nov 6, 2019 · 2 comments
Closed

Optimization of BITFIELD args generation #1175

ianpojman opened this issue Nov 6, 2019 · 2 comments
Labels
type: feature A new feature
Milestone

Comments

@ianpojman
Copy link

Feature Request

Is your feature request related to a problem? Please describe

When measuring code that uses BITFIELD intensively in profiler, I saw that a non-trivial amount of time was spent creating Redis commands (more so than actually dispatching).

I replaced String.format w/ String concatenation and profiled the app under high load and it basically became insignificant

Describe the solution you'd like

I replaced my usage of lettuce 5.1.7.RELEASE with my 6.0 snapshot with these changes
ianpojman#1

and per the profiler I saw I reasonable improvement in time spent in AbstractRedisAsyncCommands.bitfield() runtime.

Describe alternatives you've considered

Teachability, Documentation, Adoption, Migration Strategy

image
image

@ianpojman ianpojman added the type: feature A new feature label Nov 6, 2019
@mp911de
Copy link
Collaborator

mp911de commented Nov 7, 2019

Thanks a lot for having a look. Do you want to submit a pull request to fix that issue?

@ianpojman
Copy link
Author

#1178

@mp911de mp911de added this to the 5.2.2 milestone Nov 7, 2019
mp911de pushed a commit that referenced this issue Nov 7, 2019
mp911de added a commit that referenced this issue Nov 7, 2019
Add author tag. Reformat code.

Original pull request: #1178.
mp911de pushed a commit that referenced this issue Nov 7, 2019
mp911de added a commit that referenced this issue Nov 7, 2019
Add author tag. Reformat code.

Original pull request: #1178.
@mp911de mp911de closed this as completed Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

No branches or pull requests

2 participants