Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SocketAddress resolution from RedisURI to SocketAddressResolver #1157

Closed
mp911de opened this issue Oct 27, 2019 · 0 comments
Closed

Move SocketAddress resolution from RedisURI to SocketAddressResolver #1157

mp911de opened this issue Oct 27, 2019 · 0 comments
Labels
type: breaking Breaking change
Milestone
6.0 M1

Comments

@mp911de
Copy link
Collaborator

mp911de commented Oct 27, 2019

RedisURI relies on Netty Epoll/Kqueue utilities in getResolvedAddress(). We should move the resolution to SocketAddressResolver to remove Netty dependencies from RedisURI.
@mp911de mp911de added this to the 6.0 M1 milestone Oct 27, 2019
mp911de added a commit that referenced this issue Oct 27, 2019
@mp911de
Deprecate RedisURI.getResolvedAddress() #1157
c5bc975
mp911de added a commit that referenced this issue Oct 27, 2019
@mp911de
Deprecate RedisURI.password(String) in favor of password(CharSequence) …
a84cd1b 
…#1157

Requiring CharSequence is not prone for String caching if the password value is not backed by a String but rather a simple sequence of characters.
@mp911de mp911de added the type: breaking Breaking change label Dec 27, 2019
mp911de added a commit that referenced this issue Dec 27, 2019
@mp911de
Move SocketAddress resolution from RedisURI to SocketAddressResolver #…
17cea59 
…1157

The SocketAddress is now resolved using SocketAddressResolver instead of RedisURI.getResolvedAddress() to resolve a package cycle and to remove dependencies to netty when working with a plain RedisURI object.

RedisURI.getResolvedAddress() is now removed.
@mp911de mp911de closed this as completed Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: breaking Breaking change
Projects
None yet
Milestone
6.0 M1
Development

No branches or pull requests
1 participant
@mp911de