Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate Future utils #1039

Closed
mp911de opened this issue May 19, 2019 · 0 comments
Closed

Consolidate Future utils #1039

mp911de opened this issue May 19, 2019 · 0 comments
Labels
type: breaking Breaking change type: feature A new feature
Milestone
6.0 M1

Comments

@mp911de
Copy link
Collaborator

mp911de commented May 19, 2019

We have a couple of Future utilities:

  • LettuceFutures
  • RefreshFutures
  • io.lettuce.test.Futures
  • io.lettuce.core.resource.Futures
  • io.lettuce.core.internal.Futures

We should consolidate these into a single utility.
mp911de added a commit that referenced this issue Nov 9, 2019
@mp911de
Consolidate Future utils #1039
418bc1d 
Moved functionality from LettuceFutures into internal.Futures and let LettuceFutures delegate to internal.Futures. Rename resource.Futures to PromiseAdapter and remove PromiseAggregator in favor of CompletableFuture.allOf(…).
@mp911de mp911de added this to the 6.0 M1 milestone Nov 9, 2019
@mp911de mp911de closed this as completed Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: breaking Breaking change type: feature A new feature
Projects
None yet
Milestone
6.0 M1
Development

No branches or pull requests
1 participant
@mp911de