Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability for nat mapping through function #1948

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

maxbronnikov10
Copy link
Contributor

@maxbronnikov10 maxbronnikov10 commented Jan 21, 2025

The feature need when cluster nodes connected through dedicated subnet and you dont know exact host - only port
Also it would be useful if node failing and changing ip address

Changes:

  • Extend NatMap Type - union with object(previous) and function
  • Extend natMapper in Cluster for also work through function if it specified
  • Extend sentinelNatResolve in SentinelConnector for also work through function if it specified

Maybe fixes: #1003

@maxbronnikov10
Copy link
Contributor Author

@tishun Hello, sorry for tag. Can u pls review this PR? (I saw that u approved latest PR).
In iovalkey same PR merged - valkey-io/iovalkey#24

@tishun
Copy link
Contributor

tishun commented Jan 29, 2025

Hey @maxbronnikov10, seems like a good change for me.

@tishun tishun merged commit 3a04bee into redis:main Jan 29, 2025
5 checks passed
@maxbronnikov10
Copy link
Contributor Author

can u start release? For deploy last two commits

@tishun
Copy link
Contributor

tishun commented Jan 31, 2025

can u start release? For deploy last two commits

yes, we plan to release this in the following days

github-actions bot pushed a commit that referenced this pull request Feb 7, 2025
# [5.5.0](v5.4.2...v5.5.0) (2025-02-07)

### Features

* Add ability for nat mapping through function ([#1948](#1948)) ([3a04bee](3a04bee))
* **HscanStream:** adding NOVALUES option ([#1943](#1943)) ([2f9843d](2f9843d))
Copy link

github-actions bot commented Feb 7, 2025

🎉 This PR is included in version 5.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

alexandresoro pushed a commit to alexandresoro/ouca-backend that referenced this pull request Feb 8, 2025
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [ioredis](https://github.com/luin/ioredis) | dependencies | minor | [`5.4.2` -> `5.5.0`](https://renovatebot.com/diffs/npm/ioredis/5.4.2/5.5.0) |

---

### Release Notes

<details>
<summary>luin/ioredis (ioredis)</summary>

### [`v5.5.0`](https://github.com/luin/ioredis/blob/HEAD/CHANGELOG.md#550-2025-02-07)

[Compare Source](redis/ioredis@v5.4.2...v5.5.0)

##### Features

-   Add ability for nat mapping through function ([#&#8203;1948](redis/ioredis#1948)) ([3a04bee](redis/ioredis@3a04bee))
-   **HscanStream:** adding NOVALUES option ([#&#8203;1943](redis/ioredis#1943)) ([2f9843d](redis/ioredis@2f9843d))

#### [5.4.2](redis/ioredis@v5.4.1...v5.4.2) (2024-12-20)

##### Bug Fixes

-   Connection instability when using socketTimeout parameter ([#&#8203;1937](redis/ioredis#1937)) ([ca5e940](redis/ioredis@ca5e940)), closes [#&#8203;1919](redis/ioredis#1919)

#### [5.4.1](redis/ioredis@v5.4.0...v5.4.1) (2024-04-17)

##### Bug Fixes

-   remove console.log ([558497c](redis/ioredis@558497c))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjMuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE2My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca-backend/pulls/538
Reviewed-by: Alexandre Soro <code@soro.dev>
Co-authored-by: renovate <renovate@git.tristess.app>
Co-committed-by: renovate <renovate@git.tristess.app>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClusterAllFailedError: Failed to refresh slots cache.
3 participants