fix #785: defer TCP_NODELAY in async tcp connections #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @amitv87, @chris-shenzhen-china, @hunterfortuin, It would be great if you could test this PR in Windows/OSX and confirm it solves the issue. I'd love to get this fixed before we release v1.0.0. cc @yossigo I'll give the PR a good test but it looks likely this solves the issue. |
|
I've sanity-tested this on Windows 10 & Ubuntu 20.04. |
|
Awesome, thank you! It's just that I only have Windows in a VM so it's good to get verification from multiple people. |
|
@OmriSteiner @michael-grunder Looks good indeed! |
|
This looks good to me as well! |
|
Merged, thank's again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.