Adding an option to DISABLE_TESTS #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful when hiredis is used as a CMake dependency in other projects and added via add_subdirectory(). With DISABLE_TESTS on, `make test` in the parent project won't run hiredis tests.
|
@mnunberg ^ if you're the right person to tag - thanks! |
|
@michael-grunder or @yossigo, could you PTAL? (sorry, tagging random people with recent commits) |
|
This seems like a reasonable change to me, but I don't know CMake all that well. That said, the option works as I would expect so I'll merge it tomorrow assuming there aren't any objections. |
|
Merged, thanks! |
|
Thanks @michael-grunder ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful when hiredis is used as a CMake dependency in other projects and
added via add_subdirectory(). With DISABLE_TESTS on,
make testin theparent project won't run hiredis tests.