Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile does not install TLS libraries #809

Closed
theDogOfPavlov opened this issue May 17, 2020 · 2 comments
Closed

Makefile does not install TLS libraries #809

theDogOfPavlov opened this issue May 17, 2020 · 2 comments
Assignees
Labels

Comments

@theDogOfPavlov
Copy link

What do I see?

When I run the make and install, the tests complete as expected, however the TLS headers and libraries are not copied over.

What do I expect to see?

The headers and libraries should be installed as expected.

To reproduce

build

make USE_SSL=1
make install

TLS headers and libraries created as expected, but the Makefile does not copy them to the right locations

mkdir -p /usr/local/include/hiredis /usr/local/include/hiredis/adapters /usr/local/lib
cp -pPR hiredis.h async.h read.h sds.h alloc.h /usr/local/include/hiredis
cp -pPR adapters/*.h /usr/local/include/hiredis/adapters
cp -pPR libhiredis.so /usr/local/lib/libhiredis.so.0.15
cd /usr/local/lib && ln -sf libhiredis.so.0.15 libhiredis.so
cp -pPR libhiredis.a /usr/local/lib
mkdir -p /usr/local/lib/pkgconfig
cp -pPR hiredis.pc /usr/local/lib/pkgconfig
@michael-grunder
Copy link
Collaborator

michael-grunder commented May 17, 2020

I see the same thing. I'll take a closer look later today after I've had coffee 😄

As a workaround, CMake installs the SSL headers/so properly

michael-grunder added a commit to michael-grunder/hiredis that referenced this issue May 18, 2020
@michael-grunder
Copy link
Collaborator

michael-grunder commented May 18, 2020

I got this working over on my fork. I'm not sure this is the cleanest solution but it seems like both:

USE_SSL=1 make && sudo make install

and

sudo USE_SSL=1 make install

Should work to build and install the SSL libraries.

The branch in question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants