Skip to content

Commit

Permalink
Valgrind returns error exit code when errors found (#1011)
Browse files Browse the repository at this point in the history
By default Valgrind will return the exit code from the tested process.
Since our test can return 0 (ALL TESTS PASS) even when a leak was
found we need to tell Valgrind to return an error code.
This will fail the CI job when issues are found.
  • Loading branch information
bjosv authored Nov 25, 2021
1 parent 1aed21a commit b5716ee
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
# - name: Run tests under valgrind
# env:
# SKIPS_AS_FAILS: 1
# TEST_PREFIX: valgrind --track-origins=yes --leak-check=full
# TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full
# run: $GITHUB_WORKSPACE/test.sh

centos7:
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
env:
SKIPS_AS_FAILS: 1
TEST_SSL: 1
TEST_PREFIX: valgrind --track-origins=yes --leak-check=full
TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full
run: $GITHUB_WORKSPACE/test.sh

centos8:
Expand Down Expand Up @@ -115,7 +115,7 @@ jobs:
env:
SKIPS_AS_FAILS: 1
TEST_SSL: 1
TEST_PREFIX: valgrind --track-origins=yes --leak-check=full
TEST_PREFIX: valgrind --error-exitcode=99 --track-origins=yes --leak-check=full
run: $GITHUB_WORKSPACE/test.sh

macos:
Expand Down

0 comments on commit b5716ee

Please sign in to comment.