Add test codes for search_commands.go #3285
Conversation
|
Hey @tomfrombayesians , Thanks for your contribution! |
|
Hello @tomfrombayesians, there is a file |
search_commands_test.go
Outdated
| import ( | ||
| "reflect" | ||
|
|
||
| . "github.com/bsm/ginkgo/v2" | ||
| . "github.com/bsm/gomega" | ||
| "github.com/redis/go-redis/v9" | ||
| ) | ||
|
|
||
| var _ = Describe("FTAggregateQuery", func() { |
There was a problem hiding this comment.
should either be moved in search_test.go or move all the search_test.go logic here. Feel free to decide which file would you like to use.
There was a problem hiding this comment.
I move all to search_test.go and also add some label.
4316fff to
cff6483
Compare
There was a problem hiding this comment.
Overall looks good to me. Left a suggestion in one of the tests.
Thank you for the contribution, @tomfrombayesians !
| for _, a := range args { | ||
| if reflect.DeepEqual(a, 500) { | ||
| found = true | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
I assume this can be rewriten as:
| for _, a := range args { | |
| if reflect.DeepEqual(a, 500) { | |
| found = true | |
| break | |
| } | |
| } | |
| for i, a := range args { | |
| if fmt.Sprintf("%s", a) == "TIMEOUT" { | |
| Expect(fmt.Sprintf("%s", args[i+1])).To(Equal("500")) | |
| found = true | |
| break | |
| } | |
| } |
And this way will check the order of arguments as well. Right now any arg can be 500 and this test will pass.
There was a problem hiding this comment.
Oh, and added bonus, we can drop reflect as direct dependancy.
Hello!
Since this is my first PR, I added a very small test. Our team is developing Tom, an open-source AI agent that automates code maintenance tasks like writing unit tests. This code was created through collaboration between Tom and me.
Right now, our project is still private, but if you’re interested, you can sign up for the Beta Release Waitlist through this link to get notified when it becomes available.
By the way, I ran into an issue when trying to execute the tests as described in the CONTRIBUTE guide. Even after running a Redis server locally and setting the required port, I couldn’t get the full test suite to run properly. To work around this, I created a TestSuite function inside search_commands_test.go to run the Ginkgo test in isolation.
Please let me know if anything needs to be adjusted! Thanks :)