-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add readOnly on failover opts #3281
base: master
Are you sure you want to change the base?
Conversation
add failover that if is True it connects to slaves
Hello @smilad, thank you for the contribution. Would you please add a test for the change that you are introducing in this PR? |
@ndyakov : |
@smilad The test you added is skipped and won't be executed. Can we have a test that will be executed and validate the new option? |
@ndyakov : it is because of your sentinel options |
@smilad lets work together on making sure we can execute the desired test in CI. Looking at your change, having a test that tries to write to a read only client should result in an error. We can test for that? Also we can make sure we are connected to a replica. Correct? |
fixing issues :
#3277
adding ReadOnly for scenarios where you need to connect to read-only replicas is not supported in UniversalClient
by adding this I can connect to readOnly and Master separately