Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add readOnly on failover opts #3281

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

add readOnly on failover opts #3281

wants to merge 11 commits into from

Conversation

smilad
Copy link

@smilad smilad commented Feb 18, 2025

fixing issues :
#3277

adding ReadOnly for scenarios where you need to connect to read-only replicas is not supported in UniversalClient

by adding this I can connect to readOnly and Master separately

add failover that if is True it connects to slaves
@ndyakov
Copy link
Collaborator

ndyakov commented Feb 19, 2025

Hello @smilad, thank you for the contribution. Would you please add a test for the change that you are introducing in this PR?

@smilad
Copy link
Author

smilad commented Feb 19, 2025

@ndyakov :
Done

@ndyakov
Copy link
Collaborator

ndyakov commented Feb 20, 2025

@smilad The test you added is skipped and won't be executed. Can we have a test that will be executed and validate the new option?

@smilad
Copy link
Author

smilad commented Feb 22, 2025

@ndyakov : it is because of your sentinel options
and pipelines have problems
the first test case also has this issue
but if run test on local it is ok

@ndyakov
Copy link
Collaborator

ndyakov commented Feb 24, 2025

@smilad lets work together on making sure we can execute the desired test in CI. Looking at your change, having a test that tries to write to a read only client should result in an error. We can test for that? Also we can make sure we are connected to a replica. Correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants