Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: func isEmptyValue support time.Time #3273

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gh73962
Copy link

@gh73962 gh73962 commented Feb 10, 2025

This PR is based on the solution discussed in the #3208 issue.

@ndyakov
Copy link
Collaborator

ndyakov commented Feb 10, 2025

@gh73962 Thank you for the contribution. The test that you have added would have passed with or without the addition you did. Can we check what will be read so we verify the data. Maybe a raw read would work, since if we unmarshal the response to the object it would be the same as before, won't it?

@gh73962
Copy link
Author

gh73962 commented Feb 11, 2025

@gh73962 Thank you for the contribution. The test that you have added would have passed with or without the addition you did. Can we check what will be read so we verify the data. Maybe a raw read would work, since if we unmarshal the response to the object it would be the same as before, won't it?

Of course, I don't have the capability to perform this kind of test on my side. Changes like this should have comprehensive tests to ensure code quality.

@ndyakov ndyakov self-requested a review February 21, 2025 12:09
@ndyakov ndyakov changed the title fix: func isEmptyValue support time.Time feat: func isEmptyValue support time.Time Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants