-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-4494 SADD and SMEMBERS command examples #3242
base: master
Are you sure you want to change the base?
DOC-4494 SADD and SMEMBERS command examples #3242
Conversation
doctests/cmds_set_test.go
Outdated
// REMOVE_END | ||
|
||
// STEP_START smembers | ||
sMembersResult1, err := rdb.SAdd(ctx, "myset", "Hello", "World").Result() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a result of SAdd
doctests/cmds_set_test.go
Outdated
|
||
fmt.Println(sAddResult3) // >>> 0 | ||
|
||
sAddResult4, err := rdb.SMembers(ctx, "myset").Result() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a result of SMembers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @andy-stark-redis , should we rename the variables based on the comments I left?
@ndyakov The reason for the names is that all the variables with names like |
@andy-stark-redis let's try to come up with another naming convention. I do think this can be confusing to someone reading the code. Maybe something like |
@andy-stark-redis are we keeping those variable names or we are waiting for an update on this PR? |
@ndyakov I've added a new commit to change the names already. I think they are now in line with what you suggested but I'll change them if you still think they are unhelpful. |
DOC-4494 and DOC-4436.
Go examples for the
SADD
andSMEMBERS
command pages.