added Do method for raw query by single conn from pool.Conn()
#3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I want to call |
|
@vmihailenco can u make review please? |
|
@Oleglacto can you please describe your usecase and add tests? |
|
@ndyakov It is necessary to execute a raw query on a connection from the pool. Currently, this capability is not available, and workarounds such as |
|
@Oleglacto on top of my head i cannot think why this should not be possible. Any ideas? How will this behave if you are working with a connection that is in a pub/sub state? p.s. Also the test that is added is failing cc @Oleglacto |
ndyakov
requested changes
Feb 21, 2025
Comment on lines
+22
to
+26
| It("should pong with Do cmd", func() { | ||
| result := client.Conn().Do(ctx, "PING") | ||
| Expect(result.Result()).To(Equal("PONG")) | ||
| Expect(result.Err()).NotTo(HaveOccurred()) | ||
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.