Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RE tests #2847

Merged
merged 11 commits into from
Jan 1, 2024
Merged

Add RE tests #2847

merged 11 commits into from
Jan 1, 2024

Conversation

ofekshenawa
Copy link
Collaborator

No description provided.

@ofekshenawa ofekshenawa marked this pull request as ready for review December 26, 2023 14:23
@sjpotter
Copy link

dont understand why so many of the tests (all?) in commands_test.go are "non redis enterprise". many of them seem like normal commands that should work fine.

@ofekshenawa
Copy link
Collaborator Author

@sjpotter, I have labeled tests as 'non-Redis Enterprise' when they involve commands unsupported in Redis Enterprise, such as ACL commands, config, etc., and tests that result in cross-slot violations

@sjpotter
Copy link

I'm surprised that commands like blpop/brpop aren't supported in redis enterprise? but perhaps I should have?

@chayim
Copy link
Contributor

chayim commented Dec 28, 2023

IMHO we need this RedisLabs/redis-ee-docker#7

@chayim
Copy link
Contributor

chayim commented Dec 31, 2023

Willing to pull in for ee-docker#7 as a separate item.

@ofekshenawa ofekshenawa merged commit b762309 into master Jan 1, 2024
10 checks passed
@ofekshenawa ofekshenawa deleted the os-add-re-tests branch June 19, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayim chayim chayim approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofekshenawa @sjpotter @chayim