feat: support set hooks option in new client API #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zcong1993 Could you please add tests for this issue? This will allow us to continue monitoring it in the future. |
Parvezkhan0
reviewed
Nov 18, 2024
| @@ -144,6 +144,9 @@ type Options struct { | |||
|
|
|||
| // Disable set-lib on connect. Default is false. | |||
| DisableIndentity bool | |||
|
|
|||
| // Hooks are initial hooks in options like AddHook. | |||
| Hooks []Hook | |||
There was a problem hiding this comment.
The Hooks array should be validated during initialization to ensure that invalid or nil hooks are not added. This can help prevent runtime issues and maintain the integrity of the client setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2557 go-redis v9
AddHookAPI cause data race issue.This pr allow users set hooks in options for NewClient APIs, this will not cause data race. And IMO in most cases, users only need to set up hooks when initialize the client like grpc
Dial(WithUnaryInterceptor()), and not need to add hooks dynamically at runtime withAddHook.fix #2557