Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip module artifact check/errors #417

Merged
merged 1 commit into from
Apr 30, 2023

Conversation

filipecosta90
Copy link
Collaborator

Introduce a new option in run-remote to avoid raising expection on unexisting module artifacts: --continue-on-module-check-error
This is specifically designed for addition of config arg on RedisGears named v8-plugin-path https://github.com/RedisGears/RedisGears/actions/runs/4816673701/jobs/8576546334

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 5.88% and project coverage change: -0.02 ⚠️

Comparison is base (4960bf0) 55.82% compared to head (92611a2) 55.80%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #417      +/-   ##
==========================================
- Coverage   55.82%   55.80%   -0.02%     
==========================================
  Files          60       60              
  Lines        5453     5462       +9     
==========================================
+ Hits         3044     3048       +4     
- Misses       2409     2414       +5     
Impacted Files Coverage Δ
redisbench_admin/run_remote/remote_db.py 16.66% <0.00%> (-0.17%) ⬇️
redisbench_admin/run_remote/run_remote.py 23.47% <0.00%> (-0.18%) ⬇️
redisbench_admin/run_remote/standalone.py 52.38% <0.00%> (-0.85%) ⬇️
redisbench_admin/utils/remote.py 65.50% <0.00%> (+0.24%) ⬆️
redisbench_admin/run_remote/args.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@filipecosta90 filipecosta90 merged commit 8df9082 into master Apr 30, 2023
@filipecosta90 filipecosta90 deleted the extend.module.check branch April 30, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants