Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP on multi-node DB setup #405

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

WIP on multi-node DB setup #405

wants to merge 9 commits into from

Conversation

filipecosta90
Copy link
Collaborator

No description provided.

redisbench_admin/environments/oss_cluster.py Fixed Show fixed Hide fixed
)
)
ssh = SSHSession(
server_public_ip, username, key_file=open(private_key, "r")

Check warning

Code scanning / CodeQL

File is not always closed

File is opened but is not closed.
@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Patch coverage: 41.66% and project coverage change: +0.10 🎉

Comparison is base (4960bf0) 55.82% compared to head (b8200f8) 55.92%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   55.82%   55.92%   +0.10%     
==========================================
  Files          60       60              
  Lines        5453     5534      +81     
==========================================
+ Hits         3044     3095      +51     
- Misses       2409     2439      +30     
Impacted Files Coverage Δ
redisbench_admin/export/export.py 88.49% <ø> (ø)
redisbench_admin/run/redistimeseries.py 80.95% <ø> (ø)
redisbench_admin/run_local/local_db.py 75.86% <0.00%> (ø)
redisbench_admin/run_remote/remote_client.py 26.00% <ø> (ø)
redisbench_admin/run_remote/remote_db.py 14.65% <3.57%> (-2.18%) ⬇️
redisbench_admin/run/cluster.py 40.00% <5.88%> (-3.75%) ⬇️
redisbench_admin/run_remote/standalone.py 50.68% <25.00%> (-2.55%) ⬇️
redisbench_admin/utils/remote.py 67.35% <50.00%> (+2.09%) ⬆️
redisbench_admin/run/common.py 80.70% <66.66%> (-0.14%) ⬇️
redisbench_admin/run_remote/remote_env.py 79.16% <66.66%> (-4.17%) ⬇️
... and 3 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants