Spring-ified CLI #15
Merged
Spring-ified CLI #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorello89
commented
May 23, 2023
| implementation 'org.springframework.boot:spring-boot-starter' | ||
| implementation group: 'io.airlift', name: 'units', version: airliftVersion | ||
| implementation 'com.redis:lettucemod:3.5.1' | ||
| implementation files("/Users/steve.lorello/projects/smart-cache/redis-smart-cache/core/redis-smart-cache-core/build/libs/redis-smart-cache-core-0.2.2-SNAPSHOT.jar") //TODO: replace with sensible version |
There was a problem hiding this comment.
@jruaux - obviously this is pointing to a local jar at the moment (so I can get it to build at least) -when the core updates are made (or perhaps in anticipation of those from this PR) this needs to be updated to point to the appropriate version of core.
slorello89
commented
May 23, 2023
| @@ -259,264 +256,4 @@ public void setUrl(String url) { | |||
| } | |||
|
|
|||
| } | |||
|
|
|||
| public static class RulesetConfig { | |||
There was a problem hiding this comment.
RulesetConfig and RuleConfig needed to be split out to compensate for GraalVMs apparent inability to build reflection against methods of inner types
slorello89
commented
May 23, 2023
|
|
||
| import java.util.Set; | ||
|
|
||
| public class Query { |
There was a problem hiding this comment.
lifted this out into the core project
slorello89
commented
May 23, 2023
| @@ -0,0 +1,240 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
@jruaux - should this have been ignored?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.