Skip to content

Commit

Permalink
Merge pull request rh-aiservices-bu#120 from koep/ckoep_typos
Browse files Browse the repository at this point in the history
A few typo fixes and one suggestion
  • Loading branch information
guimou authored Jan 15, 2024
2 parents bc15f5e + 8d3f268 commit 50c7135
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ metadata:
internal.config.kubernetes.io/previousNames: CUSTOM - Insurance Claim Processing Lab Workbench
opendatahub.io/recommended-accelerators: '["nvidia.com/gpu"]'
opendatahub.io/notebook-image-desc: >-
Jupyter notebook image with all the libraries needed for the OpenShit AI Insurance Claim Lab.
Jupyter notebook image with all the libraries needed for the OpenShift AI Insurance Claim Lab.
argocd.argoproj.io/sync-wave: "1"
name: ic-workbench
namespace: redhat-ods-applications
Expand Down
2 changes: 1 addition & 1 deletion bootstrap/ic-rhoai-configuration/workbench-vscode-is.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ metadata:
internal.config.kubernetes.io/previousNames: CUSTOM - VSCode for Insurance Claim Processing Lab
opendatahub.io/recommended-accelerators: '["nvidia.com/gpu"]'
opendatahub.io/notebook-image-desc: >-
VSCode image for the OpenShit AI Insurance Claim Lab.
VSCode image for the OpenShift AI Insurance Claim Lab.
argocd.argoproj.io/sync-wave: "1"
name: ic-workbench-vscode
namespace: redhat-ods-applications
Expand Down
2 changes: 1 addition & 1 deletion bootstrap/workbench-image/Containerfile
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ RUN echo "Installing softwares and packages" && \
sed -i -e "s/Python.*/$(python --version | cut -d '.' -f-2)\",/" /opt/app-root/share/jupyter/kernels/python3/kernel.json && \
# Remove default Elyra runtime-images \
rm /opt/app-root/share/jupyter/metadata/runtime-images/*.json && \
# Fix permissions to support pip in Openshift environments \
# Fix permissions to support pip in OpenShift environments \
chmod -R g+w /opt/app-root/lib/python3.11/site-packages && \
fix-permissions /opt/app-root -P

Expand Down
4 changes: 2 additions & 2 deletions content/modules/ROOT/pages/02-02-creating-project.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ The instructions below will guide you through these steps. Follow them carefully

== Create a project

* First, in the OpenShift AI Dashboard application, navigate to the Data Science Project menu on the left:
* First, in the OpenShift AI Dashboard application, navigate to the Data Science Projects menu on the left:
+
[.bordershadow]
image::02/02-02-ds-proj-nav.png[]
Expand All @@ -46,7 +46,7 @@ IMPORTANT: It should **NOT** be `userX` like in the screenshot. (for you, `X` sh
== Create a Data Connection for the pipeline server

* We have deployed an instance of Minio in the cluster to act as a simple Object Storage for our purposes.
* We will need to **Add Data Connection** that points to it.
* We will need to **Add data connection** that points to it.
+
[.bordershadow]
image::02/02-02-add-dc.png[]
Expand Down
11 changes: 11 additions & 0 deletions content/modules/ROOT/pages/02-04-validating-env.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,17 @@ image::02/02-04-restart-kernel.png[]
+
. Running these cells will confirm that all the lab-required services are responding.

The output should look as follows:

[source,console]
----
Success: Minio is reachable on minio.ic-shared-minio.svc.cluster.local:9000
Success: Gitea is reachable on gitea.gitea.svc.cluster.local:3000
Success: Postgres Database is reachable on claimdb.ic-shared-db.svc.cluster.local:5432
Success: LLM Service is reachable on llm.ic-shared-llm.svc.cluster.local:3000
Success: ModelMesh is reachable on modelmesh-serving.ic-shared-img-det.svc.cluster.local:8033
----

If the output of this notebook looks suspicious, please inform the people leading the lab.

== Overall view
Expand Down

0 comments on commit 50c7135

Please sign in to comment.