[WIP] fix create service webview #2857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: - hide the commands from palette (they don't work from palette) - replace `odo application list` with a version that uses `oc` - mui5 -ify the create service form - Add a Patternfly-like dropdown for nested objects, it's collapsed by default. Still broken: - When I submit, it adds all the booleans (check boxes) into the formData, even the ones that the user hasn't interacted with. This results in invalid JSON for the custom resource, so the call to create the service fails. - form could use a few more UI clean ups Signed-off-by: David Thompson <davthomp@redhat.com>
|
Broken part might be related to rjsf-team/react-jsonschema-form#675, still need to investigate further |
|
Replaced by #3435 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
odo application listwith a version that usesocStill broken:
Signed-off-by: David Thompson davthomp@redhat.com