Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stability of Modal dialog tests #826

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Improve stability of Modal dialog tests #826

merged 1 commit into from
Jun 5, 2023

Conversation

djelinek
Copy link
Collaborator

@djelinek djelinek commented Jun 5, 2023

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@djelinek djelinek force-pushed the fixModalDialogTest branch 7 times, most recently from d1e1a8b to 00e191f Compare June 5, 2023 20:01
@djelinek
Improve stability of Modal dialog tests
ca85c00 
Signed-off-by: Dominik Jelinek <djelinek@redhat.com>
@djelinek djelinek force-pushed the fixModalDialogTest branch from 00e191f to ca85c00 Compare June 5, 2023 20:05
@djelinek djelinek marked this pull request as ready for review June 5, 2023 20:56
@djelinek djelinek merged commit b68e671 into redhat-developer:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@djelinek