Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EditorAction Page Object #790

Merged
merged 1 commit into from
May 29, 2023

Conversation

mlorinc
Copy link
Contributor

@mlorinc mlorinc commented May 23, 2023

Currently, one must call getAttribute to get Editor Action Button label which is not ideal. Also, by adding this feature it will be possible to use predicate that is more flexible than title matching.

@mlorinc mlorinc force-pushed the action-refactor branch 3 times, most recently from f6c5a6a to 3a922f9 Compare May 23, 2023 16:20
@mlorinc mlorinc marked this pull request as ready for review May 23, 2023 16:43
@mlorinc mlorinc requested a review from djelinek May 23, 2023 16:43
@mlorinc mlorinc added the ready-for-review Pull Request is Ready for Review label May 23, 2023
@mlorinc mlorinc force-pushed the action-refactor branch from 3a922f9 to ea3dd38 Compare May 23, 2023 16:43
@mlorinc mlorinc self-assigned this May 23, 2023
Signed-off-by: Marian Lorinc <mlorinc@redhat.com>
@djelinek djelinek merged commit e682ea9 into redhat-developer:main May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Pull Request is Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants