Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate Codelens actions directly to <a> element #789

Merged
merged 1 commit into from
May 29, 2023
Merged

Delegate Codelens actions directly to <a> element #789

merged 1 commit into from
May 29, 2023

Conversation

mlorinc
Copy link
Contributor

@mlorinc mlorinc commented May 23, 2023

Resolves #788

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@mlorinc mlorinc force-pushed the issue-788 branch 2 times, most recently from 7835efd to 5b52714 Compare May 23, 2023 14:09
@mlorinc mlorinc requested a review from djelinek May 23, 2023 14:30
@mlorinc mlorinc self-assigned this May 23, 2023
@mlorinc mlorinc added the ready-for-review Pull Request is Ready for Review label May 23, 2023
@mlorinc @djelinek
Delegate Codelens actions directly to <a> element
0351252 
Signed-off-by: Marian Lorinc <mlorinc@redhat.com>
@djelinek djelinek merged commit 8456b34 into redhat-developer:main May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djelinek djelinek djelinek approved these changes

Assignees

@mlorinc mlorinc

Labels
ready-for-review Pull Request is Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Codelens.click does not work in some cases
2 participants
@mlorinc @djelinek