Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): enable tests on ubuntu 24.04 #1599

Merged
merged 2 commits into from
Nov 1, 2024
Merged

chore(ci): enable tests on ubuntu 24.04 #1599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f757a4
chore(ci): enable tests on ubuntu 24.04
odockal Oct 30, 2024
a6e0b0f
extract workaround into separate CI step
djelinek Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ jobs:
- name: 🔧 Install - Test Project
run: npm install --workspace=extester-test

- name: ⚙️ Allow unprivileged user namespace (ubuntu)
run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0

- name: 📊 Run Tests with Coverage enabled
# 'set +e' and 'exit 0' - that means the workflow will not fail even the test failures are present. The failing tests are not directive for the code coverage reports itself
run: |
Expand Down
10 changes: 7 additions & 3 deletions .github/workflows/template-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu-24.04, macos-latest, windows-latest]
fail-fast: false

env:
Expand Down Expand Up @@ -52,11 +52,15 @@ jobs:
run: npm install --workspace=extester-test

- name: 🔍 Run Tests (macOS, windows)
if: matrix.os != 'ubuntu-latest'
if: ${{ ! startsWith(matrix.os, 'ubuntu') }}
run: npm test

- name: ⚙️ Allow unprivileged user namespace (ubuntu)
if: ${{ startsWith(matrix.os, 'ubuntu') }}
run: sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0

- name: 🔍 Run Tests (linux)
if: matrix.os == 'ubuntu-latest'
if: ${{ startsWith(matrix.os, 'ubuntu') }}
run: xvfb-run --auto-servernum --server-args='-screen 0 1920x1080x24' npm test

- name: 💾 Upload Screenshots
Expand Down