Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Extension Editor View #1527

Merged
merged 2 commits into from
Oct 2, 2024
Merged

feat: Add support for Extension Editor View #1527

merged 2 commits into from
Oct 2, 2024

Conversation

pospisilf
Copy link
Contributor

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

@pospisilf pospisilf force-pushed the issue-1031 branch 10 times, most recently from 1d45729 to 1c08106 Compare September 16, 2024 11:50
@pospisilf pospisilf requested a review from djelinek September 16, 2024 12:25
@pospisilf pospisilf marked this pull request as ready for review September 16, 2024 12:25
@djelinek
Copy link
Collaborator

  • please add new info page about this objects to Wiki page

@djelinek djelinek added enhancement New feature or request ready-for-review Pull Request is Ready for Review labels Sep 18, 2024
@pospisilf
Copy link
Contributor Author

Wiki is prepared here:
https://github.com/pospisilf/vscode-extension-tester/wiki/

@djelinek
Copy link
Collaborator

djelinek commented Oct 2, 2024

Wiki is prepared here: https://github.com/pospisilf/vscode-extension-tester/wiki/

Wiki is generated from docs/ folder. You can change directly in sources here --> https://github.com/redhat-developer/vscode-extension-tester/tree/main/docs

@djelinek
updates
bbdc091 
Signed-off-by: Dominik Jelinek <djelinek@redhat.com>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@djelinek djelinek linked an issue Oct 2, 2024 that may be closed by this pull request
[🚀 Request] Access to Extension README page? #1031
Closed
@djelinek djelinek merged commit af602bf into redhat-developer:main Oct 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djelinek djelinek djelinek approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ready-for-review Pull Request is Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🚀 Request] Access to Extension README page?
2 participants
@pospisilf @djelinek