Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait after killing odo during integration test #6816

Merged
merged 2 commits into from
May 15, 2023
Merged

Wait after killing odo during integration test #6816

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bee5ab6
Wait after killing odo during integration test
feloy May 15, 2023
42fbbd9
Make podman replacement terminate sooner
feloy May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/integration/cmd_dev_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ var _ = Describe("odo dev command tests", func() {
err = helper.CreateFileWithContentAndPerm(delayer, `#!/bin/bash

echo Delaying command execution... >&2
sleep 7200
sleep 10
echo "$@"
`, 0755)
Expect(err).ShouldNot(HaveOccurred())
Expand All @@ -115,7 +115,10 @@ echo "$@"
},
})
Expect(err).ShouldNot(HaveOccurred())
defer devSession.Kill()
defer func() {
devSession.Kill()
devSession.WaitEnd()
}()

Expect(string(stderrBytes)).Should(MatchRegexp("timeout \\([^()]+\\) while waiting for Podman version"))
})
Expand Down