Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make doc tests pass #6516

Merged
merged 3 commits into from
Jan 20, 2023
Merged

Make doc tests pass #6516

merged 3 commits into from
Jan 20, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jan 20, 2023 •
edited
Loading

What type of PR is this:

/kind tests

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Related to #6192

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jan 20, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit c0c2765
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63ca8a7f1ee63a00088a8c8e
😎 Deploy Preview https://deploy-preview-6516--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot requested review from kadel and rm3l January 20, 2023 09:14
@feloy feloy requested review from valaparthvi and removed request for kadel January 20, 2023 09:16
@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023 •
edited
Loading

NoCluster Tests on commit e75ad86 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023 •
edited
Loading

OpenShift Tests on commit e75ad86 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023 •
edited
Loading

Unit Tests on commit e75ad86 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023 •
edited
Loading

Validate Tests on commit e75ad86 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023 •
edited
Loading

Kubernetes Tests on commit e75ad86 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 20, 2023 •
edited
Loading

Windows Tests (OCP) on commit e75ad86 finished successfully.
View logs: TXT HTML

valaparthvi
valaparthvi suggested changes Jan 20, 2023
View reviewed changes
docs/website/docs/user-guides/quickstart/docs-mdx/go/go_odo_dev_output.mdx
@@ -23,5 +23,4 @@ $ odo dev
Keyboard Commands:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change /home/user/quickstart-demo/go-demo to /home/user/quickstart-demo and for all the *_odo_dev_output.mdx files? It is inline with some changes I have made in #6511.
You'll also need to make changes in quickstart test.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy feloy requested a review from valaparthvi January 20, 2023 12:53
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 20, 2023
@valaparthvi
Copy link
Contributor

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

  [FAIL] odo dev command tests port-forwarding for the component when devfile has single endpoint when running odo dev when modifying memoryLimit for container in Devfile [BeforeEach] should react on the Devfile modification

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

 [FAIL] odo dev command tests port-forwarding for the component when devfile has single endpoint when running odo dev when modifying memoryLimit for container in Devfile [BeforeEach] should react on the Devfile modification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Jan 20, 2023

/override ci/prow/v4.11-integration-e2e
e2e flaky test

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2023

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
e2e flaky test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit ae82d18 into redhat-developer:main Jan 20, 2023
@rm3l rm3l added this to the v3.6.0 🚀 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valaparthvi valaparthvi valaparthvi approved these changes

@rm3l rm3l Awaiting requested review from rm3l

Assignees

@valaparthvi valaparthvi

Labels
lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.6.0 🚀
Development

Successfully merging this pull request may close these issues.
4 participants
@feloy @valaparthvi @rm3l @openshift-merge-robot