Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port-forward Debug endpoints only when running odo dev with --debug #6505

Merged
merged 6 commits into from
Jan 19, 2023
Merged

Port-forward Debug endpoints only when running odo dev with --debug #6505

merged 6 commits into from
Jan 19, 2023

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jan 18, 2023

What type of PR is this:
/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #6254

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 18, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jan 18, 2023
@netlify
Copy link

netlify bot commented Jan 18, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 6799fa7
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63c9087e9d824a0008321379

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023 •
edited
Loading

OpenShift Tests on commit e46d497 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023 •
edited
Loading

NoCluster Tests on commit e46d497 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023 •
edited
Loading

Unit Tests on commit e46d497 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023 •
edited
Loading

Windows Tests (OCP) on commit e46d497 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023 •
edited
Loading

Validate Tests on commit e46d497 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 18, 2023 •
edited
Loading

Kubernetes Tests on commit e46d497 finished successfully.
View logs: TXT HTML

@rm3l rm3l force-pushed the 6254-port-forward-debug-endpoints-only-when-running-odo-dev-with-debug branch from ab5d06d to 5df760a Compare January 19, 2023 08:43
@rm3l
Use '--inspect' instead of '--inspect-brk' to run the "debug" script …
b87936e 
…in Node.JS sample projects

'--inspect-brk' stops the execution at the start of the command
(waiting for a debugger to attach to it) while '--inspect' does not.
We need the application to be started regardless of whether a debugger
is attached or not, as we are testing that we can communicate with
the forwarded ports.
@rm3l rm3l force-pushed the 6254-port-forward-debug-endpoints-only-when-running-odo-dev-with-debug branch from 5df760a to b87936e Compare January 19, 2023 08:44
@rm3l
Temporarily skip the test step on Podman that connects to the forward…
6799fa7 
…ed debug port until [1] is fixed

We can work on fixing the issue on Podman in a separate PR.

[1] redhat-developer#6510
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l
Copy link
Member Author

rm3l commented Jan 19, 2023

I added a test on Podman to check the access to the forwarded debug port, but it does not pass for some reason. See #6510
We can work on fixing this issue on Podman in a subsequent PR.

@rm3l rm3l changed the title [WIP] Port-forward debug endpoints only when running odo dev with --debug Port-forward Debug endpoints only when running odo dev with --debug Jan 19, 2023
@rm3l rm3l marked this pull request as ready for review January 19, 2023 09:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 19, 2023
@openshift-ci openshift-ci bot requested review from feloy and valaparthvi January 19, 2023 09:14
@rm3l rm3l added area/debug area/dev Issues or PRs related to `odo dev` labels Jan 19, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 19, 2023
@feloy
Copy link
Contributor

feloy commented Jan 19, 2023

/override ci/prow/v4.11-integration-e2e

Flaky test

  [FAIL] odo dev command tests port-forwarding for the component when devfile has single endpoint when running odo dev when modifying memoryLimit for container in Devfile [BeforeEach] should react on the Devfile modification

@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2023

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e

Flaky test

 [FAIL] odo dev command tests port-forwarding for the component when devfile has single endpoint when running odo dev when modifying memoryLimit for container in Devfile [BeforeEach] should react on the Devfile modification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2023

@rm3l: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.11-integration-e2e 6799fa7 link true /test v4.11-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d468842 into redhat-developer:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@feloy feloy

Labels
area/dev Issues or PRs related to `odo dev` kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port-forward debug endpoints only when running odo dev with --debug
3 participants
@rm3l @feloy @openshift-merge-robot