Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make odo dev work if no endpoint is defined #6472

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Make odo dev work if no endpoint is defined #6472

merged 3 commits into from
Jan 6, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jan 6, 2023

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6460

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jan 6, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit cff113b
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63b817648d140c0009fe7eb5

@feloy feloy requested review from rm3l and valaparthvi January 6, 2023 09:18
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 6, 2023
@openshift-ci openshift-ci bot requested a review from kadel January 6, 2023 09:18
@feloy feloy removed the request for review from kadel January 6, 2023 09:18
@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023 •
edited
Loading

NoCluster Tests on commit 7aa4e4c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023 •
edited
Loading

OpenShift Tests on commit 7aa4e4c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023 •
edited
Loading

Unit Tests on commit 7aa4e4c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023 •
edited
Loading

Validate Tests on commit 7aa4e4c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023 •
edited
Loading

Kubernetes Tests on commit 7aa4e4c finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023 •
edited
Loading

Windows Tests (OCP) on commit 7aa4e4c finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the fix-6460/no-endpoint branch from eb1e1b0 to ac0ed21 Compare January 6, 2023 10:17
rm3l
rm3l requested changes Jan 6, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few minor comments.

feloy and others added 2 commits January 6, 2023 13:38
@feloy feloy requested a review from rm3l January 6, 2023 13:14
rm3l
rm3l approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 6, 2023
@valaparthvi valaparthvi closed this Jan 6, 2023
@valaparthvi valaparthvi reopened this Jan 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-merge-robot openshift-merge-robot merged commit d982a75 into redhat-developer:main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo dev fails with no port to forward
4 participants
@feloy @rm3l @valaparthvi @openshift-merge-robot