Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in odo remove binding #6449

Conversation

valaparthvi
Copy link
Contributor

Signed-off-by: Parthvi Vala pvala@redhat.com

What type of PR is this:
/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6433

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: Parthvi Vala <pvala@redhat.com>
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 3, 2023
@netlify
Copy link

netlify bot commented Jan 3, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit e10ecaf
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63b3fcb3ac594a0008658464

@openshift-ci openshift-ci bot requested review from kadel and rm3l January 3, 2023 09:59
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@odo-robot
Copy link

odo-robot bot commented Jan 3, 2023

NoCluster Tests on commit 37690c1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 3, 2023

OpenShift Tests on commit 37690c1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 3, 2023

Unit Tests on commit 37690c1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 3, 2023

Validate Tests on commit 37690c1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 3, 2023

Kubernetes Tests on commit 37690c1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 3, 2023

Windows Tests (OCP) on commit 37690c1 finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 3, 2023
@valaparthvi valaparthvi closed this Jan 3, 2023
@valaparthvi valaparthvi reopened this Jan 3, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@rm3l
Copy link
Member

rm3l commented Jan 3, 2023

   Running oc with args [oc delete project cmd-dev-test2455ynt --wait=false] and odo env: []
    [oc] Unable to connect to the server: dial tcp: lookup api.ci-op-flnnl3c4-c362a.origin-ci-int-aws.dev.rhcloud.com on 172.30.0.10:53: no such host
  << End Captured GinkgoWriter Output
  No future change is possible.  Bailing out early - after 0.062s.
  Running oc with args [oc delete project cmd-dev-test2455ynt --wait=false] and odo env: []
  Expected
      <int>: 1
  to match exit code:
      <int>: 0
  In [AfterEach] at: /go/src/github.com/redhat-developer/odo/tests/helper/helper_cmd_wrapper.go:101

Summarizing 1 Failure:
  [FAIL] odo dev command tests [AfterEach] when a component with endpoints is bootstrapped and pushed should not create Ingress or Route resources in the cluster
  /go/src/github.com/redhat-developer/odo/tests/helper/helper_cmd_wrapper.go:101
Ran 343 of 603 Specs in 3110.821 seconds
FAIL! -- 342 Passed | 1 Failed | 0 Pending | 260 Skipped

Looks like some network errors. Overriding because all tests are passing on IBM Cloud.

/override ci/prow/v4.11-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Jan 3, 2023

@rm3l: Overrode contexts on behalf of rm3l: ci/prow/v4.11-integration-e2e

In response to this:

  Running oc with args [oc delete project cmd-dev-test2455ynt --wait=false] and odo env: []
   [oc] Unable to connect to the server: dial tcp: lookup api.ci-op-flnnl3c4-c362a.origin-ci-int-aws.dev.rhcloud.com on 172.30.0.10:53: no such host
 << End Captured GinkgoWriter Output
 No future change is possible.  Bailing out early - after 0.062s.
 Running oc with args [oc delete project cmd-dev-test2455ynt --wait=false] and odo env: []
 Expected
     <int>: 1
 to match exit code:
     <int>: 0
 In [AfterEach] at: /go/src/github.com/redhat-developer/odo/tests/helper/helper_cmd_wrapper.go:101

Summarizing 1 Failure:
 [FAIL] odo dev command tests [AfterEach] when a component with endpoints is bootstrapped and pushed should not create Ingress or Route resources in the cluster
 /go/src/github.com/redhat-developer/odo/tests/helper/helper_cmd_wrapper.go:101
Ran 343 of 603 Specs in 3110.821 seconds
FAIL! -- 342 Passed | 1 Failed | 0 Pending | 260 Skipped

Looks like some network errors. Overriding because all tests are passing on IBM Cloud.

/override ci/prow/v4.11-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 520a31e into redhat-developer:main Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in odo remove binding
3 participants