Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Quickstart guide doc to use framework specific output #6443

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Refactor Quickstart guide doc to use framework specific output #6443

merged 1 commit into from
Jan 4, 2023

Conversation

valaparthvi
Copy link
Contributor

Signed-off-by: Parthvi Vala pvala@redhat.com

What type of PR is this:
/kind feature
/area documentation

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes part of #6192

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Dec 29, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 51aa633
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63b54b09ea5ee80008cb1b95
😎 Deploy Preview https://deploy-preview-6443--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation area/documentation Issues or PRs related to documentation or the 'odo.dev' website labels Dec 29, 2022
@openshift-ci openshift-ci bot requested review from feloy and kadel December 29, 2022 10:45
@odo-robot
Copy link

odo-robot bot commented Dec 29, 2022 •
edited
Loading

OpenShift Tests on commit 720fa26 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 29, 2022 •
edited
Loading

NoCluster Tests on commit 720fa26 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 29, 2022 •
edited
Loading

Unit Tests on commit 720fa26 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 29, 2022 •
edited
Loading

Validate Tests on commit 720fa26 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 29, 2022 •
edited
Loading

Kubernetes Tests on commit 720fa26 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 29, 2022 •
edited
Loading

Windows Tests (OCP) on commit 720fa26 finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi force-pushed the refactor_quickstart_guide branch 3 times, most recently from 642e2c5 to bbd51eb Compare January 4, 2023 09:09
@valaparthvi
Refactor Quickstart guide doc to use framework specific output
51aa633 
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi valaparthvi force-pushed the refactor_quickstart_guide branch from bbd51eb to 51aa633 Compare January 4, 2023 09:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 4, 2023
@valaparthvi
Copy link
Contributor Author

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

@openshift-ci
Copy link

openshift-ci bot commented Jan 4, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 4527704 into redhat-developer:main Jan 4, 2023
@rm3l rm3l added this to the v3.6.0 🚀 milestone Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@kadel kadel Awaiting requested review from kadel

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

Assignees

@feloy feloy

Labels
area/documentation Issues or PRs related to documentation or the 'odo.dev' website kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.6.0 🚀
Development

Successfully merging this pull request may close these issues.
4 participants
@valaparthvi @feloy @rm3l @openshift-merge-robot