Rename generic run-on flag into platform #6438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…go and change runOn to platform
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
|
Kudos, SonarCloud Quality Gate passed!
|
rm3l
requested changes
Jan 2, 2023
| @@ -31,7 +31,7 @@ Learn more about the experimental mode in [this doc](../docs/user-guides/advance | |||
| <iframe width="560" height="315" src="https://www.youtube.com/embed/EmN_hGkOHX4?list=PLGMB2PY4SNOr5pjbPTdcWsIrOezCPXWdX" title="odo dev using podman" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe> | |||
|
|
|||
| You can now use`odo dev` to run your application on Podman. `odo` leverages the benefit of Podman to work seamlessly with Kubernetes YAML and replicate them to containers locally. | |||
| This is an experimental feature and can be used with `--run-on` flag. | |||
| This is an experimental feature and can be used with `--platform` flag. | |||
There was a problem hiding this comment.
I think we should keep run-on in this blog post, as it is specific and relevant to 3.3.0
| @@ -9,7 +9,10 @@ type ComponentAbstract struct { | |||
| RunningIn RunningModes `json:"runningIn"` | |||
| Type string `json:"projectType"` | |||
| // RunningOn is the platform the component is running on, either cluster or podman | |||
| // This field is deprecated and will be replaced by Platform | |||
| RunningOn string `json:"runningOn,omitempty"` | |||
There was a problem hiding this comment.
Can you also mark this field as deprecated with the // Deprecated: comment?
| // GenericRunOnFlag is the feature supporting the `--run-on` generic CLI flag. | ||
| GenericRunOnFlag = OdoFeature{ | ||
| // GenericPformFlag is the feature supporting the `--platform` generic CLI flag. | ||
| GenericPformFlag = OdoFeature{ |
There was a problem hiding this comment.
A few characters missing here - I think you meant GenericPlatformFlag ;-)
rm3l
reviewed
Jan 2, 2023
There was a problem hiding this comment.
One last comment. Can you also update the following occurrences accordingly?
$ git grep 'run-on' -- ':!docs/website/blog' ':!vendor'
tests/integration/cmd_devfile_list_test.go: It("should display component depending on experimental mode and run-on flag", func() {
tests/integration/cmd_devfile_list_test.go: By("returning component not in dev mode when experimental mode is enabled with json output and run-on is cluster", func() {
|
Closed in favor of #6445 (based on main instead of branch) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind feature
What does this PR do / why we need it:
--run-onflag with--platformodo list componentrunningOnwithplatformfield in JSON output ofodo list componentand deprecaterunningOnWhich issue(s) this PR fixes:
Fixes #6318
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: