Allow fetching specific devfile stack version #6429
Conversation
…n't work as expected Signed-off-by: Parthvi Vala <pvala@redhat.com>
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
Signed-off-by: Parthvi Vala <pvala@redhat.com>
844ba34 to
005ab28
Compare
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
b2a8c3c to
f2fa06e
Compare
| @@ -49,6 +49,9 @@ var initExample = templates.Examples(` | |||
| # Bootstrap a new component with a specific versioned devfile from registry | |||
| %[1]s --name my-app --devfile nodejs --devfile-version 2.1.0 | |||
|
|
|||
| # Bootstrap a new component with the latest devfile from registry | |||
There was a problem hiding this comment.
In the previous example:
%[1]s --name my-app --devfile nodejs
you could indicate that if several versions exist, the one marked as default will be used
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -163,6 +167,10 @@ func (o *InitClient) downloadDirect(URL string, dest string) error { | |||
| // downloadFromRegistry downloads a devfile from the provided registry and saves it in dest | |||
| // If registryName is empty, will try to download the devfile from the list of registries in preferences | |||
| func (o *InitClient) downloadFromRegistry(ctx context.Context, registryName string, devfile string, dest string) error { | |||
| // setting NewIndexSchema ensures that the Devfile library pulls registry based on the stack version | |||
| registryOptions := segment.GetRegistryOptions(ctx) | |||
| registryOptions.NewIndexSchema = true | |||
There was a problem hiding this comment.
We have to check if we need a fallback if the new index schema is not supported by the Devfile Registry. Let's keep it for another PR. The issue is tracked with #6435
|
/override windows-integration-test/Windows-test |
|
@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/v4.11-integration-e2e |
|
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind feature
What does this PR do / why we need it:
This PR allows fetching a specific devfile stack version.
Which issue(s) this PR fixes:
Fixes #6315
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
Try to fetch a Go/Springboot/Python devfile and select the version. Test with ACs described in #6315 (comment).