Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update env name for ODO_ROBOT_KEY #6393

Merged
merged 1 commit into from
Dec 12, 2022
Merged

update env name for ODO_ROBOT_KEY #6393

merged 1 commit into from
Dec 12, 2022

Conversation

anandrkskd
Copy link
Contributor

Signed-off-by: anandrkskd anandrkskd@gmail.com

What type of PR is this:

/kind bug
/kind tests

What does this PR do / why we need it:
This PR updates the ENV used for passing ODO_ROBOT key value

Which issue(s) this PR fixes:

Fixes #6392

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@anandrkskd
update env name for ODO_ROBOT_KEY
997289f 
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. kind/tests labels Dec 8, 2022
@openshift-ci openshift-ci bot requested review from feloy and kadel December 8, 2022 07:30
@netlify
Copy link

netlify bot commented Dec 8, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 997289f
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63919279dc3b7b0008138b9d

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 8, 2022
@feloy
Copy link
Contributor

feloy commented Dec 8, 2022

Thanks @anandrkskd for this fix

@feloy
Copy link
Contributor

feloy commented Dec 8, 2022

/hold
I cannot see the logs displayed in the issue. Is the key in ROBOT_KEY for CI pipeline correct?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Dec 8, 2022
@feloy feloy closed this Dec 8, 2022
@feloy feloy reopened this Dec 8, 2022
@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

NoCluster Tests on commit ff1b9f3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

Unit Tests on commit ff1b9f3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

Validate Tests on commit ff1b9f3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

Kubernetes Tests on commit ff1b9f3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

Windows Tests (OCP) on commit ff1b9f3 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

OpenShift Tests on commit ff1b9f3 finished successfully.
View logs: TXT HTML

@anandrkskd anandrkskd closed this Dec 12, 2022
@anandrkskd anandrkskd reopened this Dec 12, 2022
@feloy feloy closed this Dec 12, 2022
@feloy feloy reopened this Dec 12, 2022
@feloy feloy removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Dec 12, 2022
@feloy feloy closed this Dec 12, 2022
@feloy feloy reopened this Dec 12, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@feloy
Copy link
Contributor

feloy commented Dec 12, 2022

/override ci/prow/v4.11-integration-e2e
/override windows-integration-test/Windows-test
Non-related Flaky tests

/override podman-test/MyStage
Alpha-tests

@openshift-ci
Copy link

openshift-ci bot commented Dec 12, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e, podman-test/MyStage, windows-integration-test/Windows-test

In response to this:

/override ci/prow/v4.11-integration-e2e
/override windows-integration-test/Windows-test
Non-related Flaky tests

/override podman-test/MyStage
Alpha-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 8094d56 into redhat-developer:main Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@kadel kadel Awaiting requested review from kadel

Assignees

@feloy feloy

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ODO_ROBOT_KEY env is exposed in test log
3 participants
@anandrkskd @feloy @openshift-merge-robot