Fix flaky behavior with "list namespaces/projects -o json" integration tests #6355
Conversation
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
For some reason, "odo list namespaces/projects" would contain the current test namespace, but the subsequent "odo list namespaces/projects -o json" would no longer contain this namespace.
ffeeb25 to
d501fa0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm /override ci/prow/v4.11-integration-e2e |
|
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feloy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks for this PR. |
What type of PR is this:
/kind bug
/area testing
What does this PR do / why we need it:
I noticed repeating issues with this test on a few PRs.
For some reason,
odo list namespaces/projectswould contain the current test namespace, but the subsequentodo list namespaces/projects -o jsonwould no longer contain this namespace.After taking a look at Gomega doc, this PR changes the test so that it only relies on what is actually needed for the test and uses expectations on the JSON output only.
Which issue(s) this PR fixes:
—
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: