Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completion error when command is empty #6354

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Nov 28, 2022

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6353

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 28, 2022
@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 5e76deb
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6386017e94fee500088e569c

@openshift-ci openshift-ci bot requested review from rm3l and valaparthvi November 28, 2022 08:39
@odo-robot
Copy link

odo-robot bot commented Nov 28, 2022

NoCluster Tests on commit a2304ee finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 28, 2022

Unit Tests on commit a2304ee finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 28, 2022

Windows Tests (OCP) on commit a2304ee finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 28, 2022

Validate Tests on commit a2304ee finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 28, 2022

OpenShift Tests on commit a2304ee finished successfully.
View logs: TXT HTML

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 28, 2022
@rm3l rm3l closed this Nov 28, 2022
@rm3l rm3l reopened this Nov 28, 2022
@odo-robot
Copy link

odo-robot bot commented Nov 28, 2022

Kubernetes Tests on commit a2304ee finished successfully.
View logs: TXT HTML

@feloy feloy closed this Nov 28, 2022
@feloy feloy reopened this Nov 28, 2022
@feloy feloy force-pushed the bugfix/completion-list-namespaces branch from ad7b0ec to 5e76deb Compare November 29, 2022 12:56
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 29, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 29, 2022

New changes are detected. LGTM label has been removed.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l rm3l added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 29, 2022
@rm3l
Copy link
Member

rm3l commented Nov 29, 2022

Expected
      <*url.Error | 0xc0002e0120>: {
          Op: "Post",
          URL: "http://127.0.0.1:56448/api/newuser",
          Err: <*errors.errorString | 0xc000184100>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/2637/tests/e2escenarios/e2e_test.go:287

Overriding because the previous test run passed with the same changes.

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Nov 29, 2022

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

Expected
     <*url.Error | 0xc0002e0120>: {
         Op: "Post",
         URL: "http://127.0.0.1:56448/api/newuser",
         Err: <*errors.errorString | 0xc000184100>{s: "EOF"},
     }
 to be nil
 In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/2637/tests/e2escenarios/e2e_test.go:287

Overriding because the previous test run passed with the same changes.

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member

rm3l commented Nov 30, 2022

/override ci/prow/v4.11-integration-e2e

All tests are passing on IBM Cloud.

@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2022

@rm3l: Overrode contexts on behalf of rm3l: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e

All tests are passing on IBM Cloud.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit c4c29a1 into redhat-developer:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion panics
3 participants