Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump odo version to v3.3.0 #6325

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Bump odo version to v3.3.0 #6325

merged 1 commit into from
Nov 22, 2022

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes part of #6261

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Nov 22, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 82364c2
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/637c7a36c128880008d8d6cc

@openshift-ci openshift-ci bot requested review from feloy and rnapoles-rh November 22, 2022 05:37
@valaparthvi
Copy link
Contributor Author

/hold
Until #6255 goes in.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Nov 22, 2022
@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022 •
edited
Loading

NoCluster Tests on commit e8d113d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022 •
edited
Loading

Unit Tests on commit e8d113d finished successfully.
View logs: TXT HTML

@valaparthvi
Copy link
Contributor Author

/hold cancel
#6255 is in.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Nov 22, 2022
@anandrkskd
Copy link
Contributor

@valaparthvi this file should also be updated with the new version, right?

@valaparthvi
Copy link
Contributor Author

valaparthvi commented Nov 22, 2022 •
edited
Loading

@valaparthvi this file should also be updated with the new version, right?

I believe that file should be updated after the binaries are released. At least, that's what the bump-version script says.

echo "* Don't forget to update build/VERSION once the binaries become available !            *"

@anandrkskd
Copy link
Contributor

I believe that file should be updated after the binaries are released. At least, that's what the bump-version script says.

Understood! Thanks
/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 22, 2022
@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022 •
edited
Loading

Validate Tests on commit e8d113d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022 •
edited
Loading

Windows Tests (OCP) on commit e8d113d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022 •
edited
Loading

OpenShift Tests on commit e8d113d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 22, 2022 •
edited
Loading

Kubernetes Tests on commit e8d113d finished with errors.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Nov 22, 2022

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandrkskd, feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 22, 2022
@feloy feloy closed this Nov 22, 2022
@feloy feloy reopened this Nov 22, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 22, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@valaparthvi
Copy link
Contributor Author

@feloy can you also add approve?

@anandrkskd
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 22, 2022
@feloy
Copy link
Contributor

feloy commented Nov 22, 2022

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

Flaky test

[FAILED] [287.834 seconds]
odo dev command tests
/go/odo_1/tests/integration/cmd_dev_test.go:31
  port-forwarding for the component
  /go/odo_1/tests/integration/cmd_dev_test.go:552
    when devfile has single endpoint
    /go/odo_1/tests/integration/cmd_dev_test.go:553
      when running odo dev
      /go/odo_1/tests/integration/cmd_dev_test.go:560
        when modifying memoryLimit for container in Devfile [BeforeEach]
        /go/odo_1/tests/integration/cmd_dev_test.go:590
          should expose the endpoint on localhost
          /go/odo_1/tests/integration/cmd_dev_test.go:606

@openshift-ci
Copy link

openshift-ci bot commented Nov 22, 2022

@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

Flaky test

[FAILED] [287.834 seconds]
odo dev command tests
/go/odo_1/tests/integration/cmd_dev_test.go:31
 port-forwarding for the component
 /go/odo_1/tests/integration/cmd_dev_test.go:552
   when devfile has single endpoint
   /go/odo_1/tests/integration/cmd_dev_test.go:553
     when running odo dev
     /go/odo_1/tests/integration/cmd_dev_test.go:560
       when modifying memoryLimit for container in Devfile [BeforeEach]
       /go/odo_1/tests/integration/cmd_dev_test.go:590
         should expose the endpoint on localhost
         /go/odo_1/tests/integration/cmd_dev_test.go:606

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Nov 22, 2022

/override ci/prow/v4.11-integration-e2e
Tests pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Nov 22, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 1d31586 into redhat-developer:main Nov 22, 2022
@rm3l rm3l added this to the v3.3.0 🚀 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy Awaiting requested review from feloy

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

Assignees

@anandrkskd anandrkskd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.3.0 🚀
Development

Successfully merging this pull request may close these issues.
5 participants
@valaparthvi @anandrkskd @feloy @rm3l @openshift-merge-robot