Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable loading a single branch when getting git starter project #6290

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Disable loading a single branch when getting git starter project #6290

merged 2 commits into from
Nov 7, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Nov 7, 2022

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6232

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 7, 2022
@openshift-ci openshift-ci bot requested review from dharmit and valaparthvi November 7, 2022 07:53
@netlify
Copy link

netlify bot commented Nov 7, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 2a2f429
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6368d5832c8a8300082192b4

@odo-robot
Copy link

odo-robot bot commented Nov 7, 2022 •
edited
Loading

NoCluster Tests on commit f3dc711 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 7, 2022 •
edited
Loading

Unit Tests on commit f3dc711 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 7, 2022 •
edited
Loading

Validate Tests on commit f3dc711 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 7, 2022 •
edited
Loading

Windows Tests (OCP) on commit f3dc711 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 7, 2022 •
edited
Loading

Kubernetes Tests on commit f3dc711 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 7, 2022 •
edited
Loading

OpenShift Tests on commit f3dc711 finished successfully.
View logs: TXT HTML

@kadel kadel changed the title Disable loading a sibgle branch when getting git starter project Disable loading a single branch when getting git starter project Nov 7, 2022
@kadel
Copy link
Member

kadel commented Nov 7, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 7, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 7, 2022
@rm3l
Copy link
Member

rm3l commented Nov 7, 2022

Would it make sense to add a test case (E2E maybe) for this, to catch potential future regressions?

@feloy feloy force-pushed the bugfix-6232/starter-git-branch branch from 6003af8 to bb7e348 Compare November 7, 2022 09:44
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 7, 2022
@feloy feloy closed this Nov 7, 2022
@feloy feloy reopened this Nov 7, 2022
rm3l
rm3l approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I noticed that odo currently does not support checking out from a specific commit ID (branches and tags work great). But this is not related to the changes in this PR. I'll create a separate issue.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 7, 2022
@feloy feloy closed this Nov 7, 2022
@feloy feloy reopened this Nov 7, 2022
@feloy feloy closed this Nov 7, 2022
@feloy feloy reopened this Nov 7, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@feloy
Copy link
Contributor Author

feloy commented Nov 7, 2022

/test ci/prow/v4.11-integration-e2e

@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2022

@feloy: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test unit-and-validate-test
  • /test v4.10-images
  • /test v4.11-images
  • /test v4.11-integration-e2e
  • /test v4.12-images
  • /test v4.9-images

Use /test all to run all jobs.

In response to this:

/test ci/prow/v4.11-integration-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Nov 7, 2022

/test v4.11-integration-e2e

1 similar comment
@feloy
Copy link
Contributor Author

feloy commented Nov 7, 2022

/test v4.11-integration-e2e

@feloy
Copy link
Contributor Author

feloy commented Nov 7, 2022

/override v4.11-integration-e2e
Tests pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2022

@feloy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • v4.11-integration-e2e

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • NoCluster-Integration-tests/NoCluster-Integration-tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/unit-and-validate-test
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.11-integration-e2e
  • ci/prow/v4.12-images
  • ci/prow/v4.9-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-unit-and-validate-test
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.11-integration-e2e
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.9-images
  • tide
  • validator/Validate
  • windows-integration-test/Windows-test

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override v4.11-integration-e2e
Tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Nov 7, 2022

/override ci/prow/v4.11-integration-e2e
Tests pass on IBM Cloud

@openshift-ci
Copy link

openshift-ci bot commented Nov 7, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Tests pass on IBM Cloud

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 4c7ab35 into redhat-developer:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@dharmit dharmit Awaiting requested review from dharmit

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@kadel kadel

@rm3l rm3l

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo init - cloning wrong branch of starterProject
4 participants
@feloy @kadel @rm3l @openshift-merge-robot